search

nodejs / amaro

Node.js TypeScript wrapper
MIT License
259 stars 11 forks source link

update transform tests to match node #60

Open marco-ippolito opened 1 month ago

marco-ippolito commented 1 month ago

We added a new option to transformSync https://github.com/nodejs/node/pull/54283/files#diff-fddf8a06747f8c9e83cd2a3ebee0f53dbd790567ce018044e70bd0ffbbcc815eR357-R370

We need to match in tests and snapshots

mertcanaltin commented 1 month ago

I wonder if this includes the newly added transform tests?

raashidanwar commented 1 month ago

@marco-ippolito I would like to pick this up.

marco-ippolito commented 1 month ago

@marco-ippolito I would like to pick this up.

sure go ahead

raashidanwar commented 1 month ago

@marco-ippolito I would like to pick this up.

sure go ahead

Would be glad if you give me more details and any references to start.

raashidanwar commented 1 month ago

@marco-ippolito The test and snapshots change will be in node not in amaro right?

marco-ippolito commented 1 month ago

It will be in Amaro

raashidanwar commented 1 month ago

@marco-ippolito I can see the option is already there in the test case https://github.com/nodejs/amaro/blob/main/test/transform.test.js. Can you tell me what other new field we need to add to the test case?

raashidanwar commented 1 month ago

Here is the PR 👉 https://github.com/nodejs/amaro/pull/67 @marco-ippolito , All the options are already there.

ScrabyQ commented 1 month ago

@marco-ippolito Do you mean implementing similar tests from this PR in amaro?