nodejs / build-containers

Docker images used to test pull requests from untrusted sources
29 stars 11 forks source link

`s/-j8/-j4` for build parallelisation #16

Closed rvagg closed 9 years ago

rvagg commented 9 years ago

Because we're running all of these together, currently over 2 8-core machines but as we increase the number of containers we'll have to balance the number of machines to the build parallelisation. I think that currently 4 is a good compromise between our needs and making these containers useful to others, 8 is just too much.

retrohacker commented 9 years ago

Would it be wise to detect the number of cores of the server and use that for the build? I.E. -j$(nproc) or some function of nproc?

rvagg commented 9 years ago

@wblankenship not a bad idea but I'm also not sure it's worth it yet. If you want to propose in a PR then go ahead. We're running 8-core machines now and want to end up between 2 - 4 for each of these processes I think.