search

nodejs / build-containers

Docker images used to test pull requests from untrusted sources
29 stars 11 forks source link

Dockerfiles for iojs and libuv on debian stable and testing #5

Closed ghostbar closed 9 years ago

ghostbar commented 9 years ago

I made the user iojs and the /opt/node is /opt/iojs.

Let me know if this is OK or I should change it.

ghostbar commented 9 years ago

This is not yet ready, although @rvagg I would like some feedback on how you're planning to have the data on the /opt/{libuv,iojs} directories. You want the output on the host system?

rvagg commented 9 years ago

Have a look at the build output for how these are run: https://jenkins-node-forward.nodesource.com/job/iojs+any-pr+containers/nodes=node-forward-digitalocean-containers-ubuntu+trusty/lastBuild/consoleFull

There is a git checkout and then it launches docker as part of the normal flow, capturing the output and exit code as if it's a normal test executable.

rvagg commented 9 years ago

I'll change them all to use "iojs" so your change is fine.