search

nodejs / build-containers

Docker images used to test pull requests from untrusted sources
29 stars 11 forks source link

Docker Hub repo #8

Closed rvagg closed 9 years ago

rvagg commented 9 years ago

https://registry.hub.docker.com/u/iojs/build/

Should be able to docker run iojs:iojs-ubuntu-trusty and docker run iojs:libuv-ubuntu-trusty to pull the builds from Docker Hub.

Debian builds are not working, an adduser thing: https://registry.hub.docker.com/u/iojs/build/builds_history/95020/ / @ghostbar

Happy to discuss naming or anything else in this thread. We also should probably update the README with more details, #6 needs a bit of work based on the feedback I gave there and we should mention Hub.

Once this is working nicely we'll switch the build machines to pull from there and not have to run their own builds.

rvagg commented 9 years ago

I've added @wblankenship to the Docker Hub repo since he has a lot of experience maintaining the NodeSource ones. If @ryanstevens and @ghostbar have Docker Hub accounts I can add you there too if you think it helpful.

rvagg commented 9 years ago

actually, the full command would be:

docker run -a stdin -a stdout -a stdin -t --rm -v /local/path/to/iojs:/opt/iojs iojs/build:iojs-ubuntu-trusty

That's how they'll be run on the build servers.

ghostbar commented 9 years ago

@rvagg any way to get the build logs from the docker hub? Want to make sure is what I think it is (Expects mounting the volume from a user named node-forward)

ghostbar commented 9 years ago

BTW, it's helpful to be on the docker hub because that way I can actually see the logs and know what it's failing :) I'm ghostbar over there as well, @rvagg.

rvagg commented 9 years ago

@ghostbar you just have to scroll down and click on the build id of failed builds to see the logs: https://registry.hub.docker.com/u/iojs/build/build_id/29222/code/bxhwjkvws9x3whynn9fktzg/ (perhaps you need to be logged in for this?). Adding you there now.

ghostbar commented 9 years ago

@rvagg now I can see them. I figured out the link part since I actually made my on repos there on the Docker Hub and saw I had links on the IDs and not on the iojs/build repo :)

Thanks.

ghostbar commented 9 years ago

I think this is completely done, let me know if there's something else to be done so I can work on it today @rvagg