search

nodejs / build

Better build and test infra for Node.
507 stars 166 forks source link

Offboard inactive members #2390

Closed AshCripps closed 4 years ago

AshCripps commented 4 years ago

Follow on from #2357 and #2358

Checklist for the offboarding of the following members:

@LucaLanziani (build) @maclover7 (build and jenkins) @addaleax (build) @gireeshpunathil (build)

Thank you all for your contributions and you will be welcomed back if you wish to return!

Offboarding issue checklist

AshCripps commented 4 years ago

@nodejs/build anyone had any experience as to when I tried to clean up these keys from secrets it deleted the inventory.yml file as well? (I did also try to clean up an old keys of georges that was still left in the folder)

jbergstroem commented 4 years ago

@AshCripps haven't seen that. Did you use dotgpg rm to remove the keys?

AshCripps commented 4 years ago

yep I did get some gem errors though - 

/Library/Ruby/Gems/2.3.0/gems/gpgme-2.0.19/lib/gpgme/ctx.rb:385:in `import_keys': Too many open files (GPGME::Error)
rvagg commented 4 years ago

Silly low open files limit on macos, you need to increase the limit, ulimit -n 10000 or something. There's a more advanced command that sets it permanently but I don't have that at hand. Check out a clean copy of the repo, lift the limit in your current shell and run it again.

AshCripps commented 4 years ago

Removed from the secrets repo - all except luca's key got not a valid gpg key for that one. Will need someone to remove @maclover7's key from githubbot secrets as I dont have access and then someone to remove the above from the github teams as im not a maintainer.

rvagg commented 4 years ago

done

AshCripps commented 4 years ago

Can the one of the members of build with TSC overlord powers remove the poeple at the top of the issue from the respective teams please? @mhdawson @Trott @mmarchini

mhdawson commented 4 years ago

@AshCripps done, does not look like there is a nodejs/build-release team, was that the right name?

AshCripps commented 4 years ago

build-release is referring to secrets team I believe

mhdawson commented 4 years ago

@AshCripps there is no team specifically related to secrets but those in the nodejs-private/build team have access to the secrets repo. I've remove the inactive members from that team so I think we should be good.

mmarchini commented 4 years ago

Is build-release referring to the private keys instead of a team?

AshCripps commented 4 years ago

Is build-release referring to the private keys instead of a team?

sorry yes its referring to those you have access to the keys - theres no "team" as such cause there doesnt need to be.

AshCripps commented 4 years ago

Closing as complete.