nodejs / build

Better build and test infra for Node.
504 stars 165 forks source link

Jenkins security release June 30th #2688

Closed rvagg closed 2 years ago

rvagg commented 3 years ago

The Jenkins project plans to publish new Jenkins releases (weekly and LTS 2.289.2) on Wednesday, June 30. These updates will contain fixes for security issues present in current versions of Jenkins. The highest severity is "High". The security advisory will be issued at the same time to provide further information.

rvagg commented 3 years ago

Releases and advisory are out: https://www.jenkins.io/security/advisory/2021-06-30/

My judgement is that, while not trivial, these shouldn't be a major concern for our usage model and we can wait until after the security releases tomorrow to get an upgrade done. Happy to hear alternative views though.

richardlau commented 3 years ago

I've run apt-get update && apt dist-upgrade -y && apt-get autoremove -y on both ci.nodejs.org and ci-release.nodejs.org and both are now 2.289.2.

@rvagg How did you generate the list of updated plugins in e.g. https://github.com/nodejs/build/issues/2593? I haven't touched the plugin manager yet -- I'd like to be able to record what plugins were updated like in the previous issues.

richardlau commented 3 years ago

As per image I've set the executors for the master/controller node to 0 on ci.nodejs.org.

We get the same warning on ci-release.nodejs.org but we are actually running iojs+release on the master node, so I've left it as-is for the moment.

richardlau commented 3 years ago

FWIW the new version of Jenkins includes https://github.com/jenkinsci/jenkins/pull/5065 so we have new icons, e.g. image

targos commented 3 years ago

The new icons for running jobs are... interesting 😄

https://user-images.githubusercontent.com/2352663/124194301-9c911400-dac8-11eb-9e10-2591c098d534.mov

rvagg commented 3 years ago

@richardlau I just copy the text of the plugin manager page into my editor and do some munging until it ends up in a form I can post here .. usually involves a bit of manual work and it's a bit tedious but I reckon it's worth recording these version numbers in case we need to revert anything (which we've had to do in the past).

Have run upgrades now:

ci plugins

Not upgraded:

Upgraded:

ci-release plugins

Not upgraded:

Upgraded:

rvagg commented 3 years ago

that weird UI bug might be fixed by upgrading the CSS if someone wants to go to the skin site (url at bottom right) and copypaste in appropriate CSS, maybe they have an update for the new Jenkins

richardlau commented 3 years ago

I just copy the text of the plugin manager page into my editor and do some munging until it ends up in a form I can post here .. usually involves a bit of manual work and it's a bit tedious but I reckon it's worth recording these version numbers in case we need to revert anything (which we've had to do in the past).

Yeah, I agree that recording the numbers is useful which I why I asked. Manual it is then 🙂.

that weird UI bug might be fixed by upgrading the CSS if someone wants to go to the skin site (url at bottom right) and copypaste in appropriate CSS, maybe they have an update for the new Jenkins

I've applied the workaround in https://github.com/afonsof/jenkins-material-theme/issues/183#issuecomment-806518351 to hide the spinning animation.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.