search

nodejs / build

Better build and test infra for Node.
507 stars 166 forks source link

New LTS daily jobs #3555

Open StefanStojanovic opened 1 year ago

StefanStojanovic commented 1 year ago

We currently have 2 LTS daily jobs that are disabled because of their EOL: node-daily-v14.x-staging and node-daily-v16.x-staging. On the other hand. we do not have daily builds for currently active LTS versions v18 and v20. I'd like to change that.

I have a question for @nodejs/build regarding that: Can I just rename the 2 existing jobs and change their parameters so they build the two new LTS versions, or should I make their copies, set them up, and then delete the old ones?

richardlau commented 1 year ago

I'd make copies so that the build history isn't polluted. Please keep the 16.x one around for now until March/April 2023: https://github.com/nodejs/build/blob/d8c6863e6dc588d992b377563de7ee4da4060b71/README.md?plain=1#L294-L296

StefanStojanovic commented 1 year ago

I deleted the v14 job and added the v18 and v20 ones. As suggested, I left the v16 job. I'll check the runs new jobs had over the weekend on Monday and if all is OK, close this issue.

StefanStojanovic commented 12 months ago

The jobs are created and they are running daily. However, both have been red since starting, and failures are happening on various platforms. As I recall we've been marking some tests flaky on Windows recently to stabilize the CI. Maybe something similar should be done for the LTS branches as well.