search

nodejs / build

Better build and test infra for Node.
507 stars 166 forks source link

Hetzner Benchmarking Machine Replacements #3657

Open ryanaslett opened 7 months ago

ryanaslett commented 7 months ago

The procurement process has completed, and I have created two EX44's (https://www.hetzner.com/dedicated-rootserver/ex44/) at Hetzner.

If all goes well we should be able to have these online and running benchmark tests.

I believe the next steps are

  1. Get access to the secrets repo
  2. Configure machines with ansible
  3. Get admin for the ci.nodejs.org to add them to jenkins
  4. test them
thisalihassan commented 6 months ago

@rluvaton sure also where can I see the logs?

rluvaton commented 6 months ago

You have this example: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1514/consoleFull

but you can run locally

richardlau commented 6 months ago

FWIW there's a difference in output, e.g. https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/1510/console

21:42:04 "new","test_runner/suite-tests.js","concurrency='no' testType='async' testsPerSuite=1000 numberOfSuites=100",34812.26643390852,2.872550691

vs https://ci.nodejs.org/job/benchmark-node-micro-benchmarks/1513/console

13:39:14 test_runner/suite-tests.js concurrency="no" testType="async" testsPerSuite=1000 numberOfSuites=100: 29,112.48474928658

i.e. as if the "new", (or "old",) field and opening " of the second field is missing.

rluvaton commented 6 months ago

also found this:

thisalihassan commented 6 months ago

@rluvaton https://github.com/nodejs/node/pull/52456 "ipc" I untintentially removed this in the spawn stdio, that's why child.on message wasn't listening events

in Fork IPC is established by default but in spawn it is not established by default hence listener wasn't working