search

nodejs / build

Better build and test infra for Node.
503 stars 165 forks source link

[2025-03-18] Upgrade to Artifact Registry #3768

Open trivikr opened 2 months ago

trivikr commented 2 months ago

Is your feature request related to a problem? Please describe.

Container Registry is deprecated and scheduled for shutdown on 2025-03-18. Google Cloud recommends upgrading to Artifact Registry: https://cloud.google.com/artifact-registry/docs/transition/prepare-gcr-shutdown

The nodejs-org project uses Container Registry

$ gcloud container images list-gcr-usage --project=nodejs-org --filter="usage=ACTIVE"
---
repository: gcr.io/nodejs-org
usage: ACTIVE

Describe the solution you'd like

Follow guide for Set up repositories with gcr.io domain support https://cloud.google.com/artifact-registry/docs/transition/setup-gcr-repo

Additional context

Refs: https://github.com/nodejs/build/issues/3697#issuecomment-2137861247

mhdawson commented 2 months ago

@trivikr do you know what the project uses gcr.io for right now?

richardlau commented 2 months ago

@trivikr do you know what the project uses gcr.io for right now?

The metrics stuff running on GCP is all running on containers on gcr.io. We appear to be missing documentation and/or automation on how to rebuild/update/upload the containers.

mhdawson commented 2 months ago

@richardlau is that everything? Just wanted to be sure there was nothing beyond the metrics stuff.

richardlau commented 2 months ago

AFAIK

trivikr commented 2 months ago

When I looked at GCP Container registry for errors as part of debugging download stats in https://github.com/nodejs/build/issues/3697, I verified that they contain docker images for only running metrics stuff as Richard mentioned.

We appear to be missing documentation and/or automation on how to rebuild/update/upload the containers.

That's right. I posted GCP docs for Container Registry in Node.js 20 upgrade PR in https://github.com/nodejs/build/pull/3767#issuecomment-2177349927, and GCP Artifact Registry docs in this issue description to follow whenever migration is prioritized.