search

nodejs / build

Better build and test infra for Node.
502 stars 164 forks source link

The processlogs script sometimes throws "Memory limit of 1430 MiB exceeded" #3770

Closed trivikr closed 15 hours ago

trivikr commented 2 weeks ago

Describe the issue

The processlogs script sometimes throws "Memory limit of 1430 MiB exceeded"

Steps to reproduce

View if you have access https://cloudlogging.app.goo.gl/J3n4QFpWFxwmjosc7

Observed behavior

The request failed because either the HTTP response was malformed or connection to the instance had an error. Additional troubleshooting documentation can be found at: https://cloud.google.com/run/docs/troubleshooting#malformed-response-or-connection-error
While handling this request, the container instance was found to be using too much memory and was terminated. This is likely to cause a new container instance to be used for the next request to this revision. If you see this message frequently, you may have a memory leak in your code or may need more memory. Consider creating a new revision with more memory.

Memory limit of 1430 MiB exceeded with 1501 MiB used. Consider increasing the memory limit, see https://cloud.google.com/run/docs/configuring/memory-limits

Expected behavior

No Memory limit error

Additional context

Noticed while reviewing logs in https://github.com/nodejs/build/issues/3697#issuecomment-2137861247

trivikr commented 2 weeks ago

It would be beneficial to revisit this after updating Node.js to 20.x in https://github.com/nodejs/build/pull/3767

trivikr commented 15 hours ago

Closing as this error hasn't been thrown since 2024-06-06, and we've recently done bunch of updates in metrics scripts which helped fix many other issues https://github.com/nodejs/build/commits/main/ansible/roles/metrics