nodejs / build

Better build and test infra for Node.
502 stars 165 forks source link

Access to Windows Machine #3795

Closed RafaelGSS closed 1 week ago

RafaelGSS commented 2 weeks ago

I need access to the windows win-10-vs2019 to diagnostic https://ci.nodejs.org/job/node-test-binary-windows-js-suites/28385/RUN_SUBSET=1,nodes=win10-COMPILED_BY-vs2019/testReport/junit/(root)/parallel/test_child_process_spawn_windows_batch_file/ error.

Thanks!

StefanStojanovic commented 2 weeks ago

I can set it up for you later during the day. Is that time window OK for you?

RafaelGSS commented 2 weeks ago

Ok

StefanStojanovic commented 2 weeks ago

@RafaelGSS I've created the machine, but Node.js can no longer be compiled with VS 2019 (only VS 2022 now), so you cannot use that machine for the compilation of your branch, You can still of course download the binaries you want and run the tests. Is that enough for you? I've sent you the access parameters via email. If you need any more help, please don't hesitate to let me know. Regards.

RafaelGSS commented 2 weeks ago

I don't know if you have access to it, but I need to test a v20 patch. More specifically https://ci.nodejs.org/job/node-test-binary-windows-js-suites/28399/RUN_SUBSET=2,nodes=win2019-COMPILED_BY-vs2019/testReport/junit/(root)/parallel/test_permission_fs_windows_path/.

Can I get access to this exact machine?

StefanStojanovic commented 1 week ago

From what I'm seeing, this ran on machine test-rackspace-win2019_vs2019-x64-2, although I assume any test-rackspace-win2019_vs2019-x64-* machine would do. Btw, that is the machine that the test was ran on, not necessarily (most likely it is not) the machine that produced the binaries.

Since it is a v29 build, it can be compiled with VS2019, so the machine I've sent you the access to should do the job.

On the other hand, the link you sent in your last comment, differs from the one in the issue description - different test failing and different machine type, so I'm currently a bit lost on the exact machine (OS and VS version) and failing test you need help with.

RafaelGSS commented 1 week ago

I could reproduce it in the machine you provided! Patch is on the way, thank you.

StefanStojanovic commented 1 week ago

Hey @RafaelGSS I'll be OOF from Thursday, so I wanted to check if you need something else from me while I'm still here.

RafaelGSS commented 1 week ago

I have finished the debugging. Thank you!