nodejs / build

Better build and test infra for Node.
507 stars 166 forks source link

Add versions of `sqlite` and `swc` on the `dist.json` #3847

Open ovflowd opened 3 months ago

ovflowd commented 3 months ago

Opening an issue to have the versions of sqlite and swc bundled with Node.js to be defined within the dist.json so that the Website can grab that metadata and add this information on the Downloads page.

Also, @marco-ippolito, do you believe it possible to infer the typescript compiler version from the src/wasm-typescript version (?), or does that package not rely on the typescript binary itself?

cc @nodejs/build

marco-ippolito commented 3 months ago

the typescript version is documented here: https://github.com/nodejs/amaro?tab=readme-ov-file#typescript-version, its currently extracted from the readme of swc

ovflowd commented 3 months ago

the typescript version is documented here: nodejs/amaro#typescript-version, its currently extracted from the readme of swc

Is there any update here, manual? (i.e. the version is the same across the board, and only a manual update by a collaborator would change the version?) Thanks for the info, 🤦 to me for not looking it there 😅

richardlau commented 3 months ago

There is no dist.json 🙂.

The tool that generates index.json and index.tab is https://github.com/nodejs/nodejs-dist-indexer. That works based on GitHub tags, e.g. when indexing Node.js 22.5.1 it will read from GitHub the source at tag v22.5.1. When modifying the tool it needs to be able to cope with the information being missing (e.g. sqlite not present on older releases).

ovflowd commented 3 months ago

There is no dist.json 🙂.

Sorry it was a typo, I meant dist/index.json