Closed richardlau closed 1 month ago
11:21:16 Failed to fetch file gs://chromium-clang-format/b42097ca924d1f1736a5a7806068fed9d7345eb4 for buildtools/linux64/clang-format. [Err: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/depot_tools/external_bin/gsutil/gsutil_4.68/gsutil/gslib/vendored/boto/boto/pyami/config.py:69: UserWarning: Unable to load AWS_CREDENTIAL_FILE ()
I'm slightly surprised to be downloading something with linux64
in its path on s390x, but I don't think this is new -- I think this is coming from https://github.com/nodejs/node/blob/90dea9e3e003945f113aaca09c45f963fe566a47/deps/v8/DEPS#L498-L509 and that isn't recent.
As a quick test I tried disabling hooks in fetch_deps.py
:
diff --git a/tools/v8/fetch_deps.py b/tools/v8/fetch_deps.py
index b7e628608a..51f9cc8ef1 100755
--- a/tools/v8/fetch_deps.py
+++ b/tools/v8/fetch_deps.py
@@ -79,7 +79,7 @@ def FetchDeps(v8_path):
env["PATH"] = depot_tools + os.pathsep + env["PATH"]
gclient = os.path.join(depot_tools, "gclient.py")
spec = "solutions = %s" % GCLIENT_SOLUTION
- subprocess.check_call([sys.executable, gclient, "sync", "--spec", spec],
+ subprocess.check_call([sys.executable, gclient, "sync", "--spec", spec, "--nohooks"],
cwd=os.path.join(v8_path, os.path.pardir),
env=env)
except:
https://ci.nodejs.org/job/node-test-commit-v8-linux/6118/
Unfortunately while that does appear to have allowed s390x to fetch dependencies and start building, it has broken the x64 build.
I think it might be possible to set custom_hooks
in the spec we pass to gclient sync, but I haven't yet been able to get that working on s390x.
11:21:16 Failed to fetch file gs://chromium-clang-format/b42097ca924d1f1736a5a7806068fed9d7345eb4 for buildtools/linux64/clang-format. [Err: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/third_party/depot_tools/external_bin/gsutil/gsutil_4.68/gsutil/gslib/vendored/boto/boto/pyami/config.py:69: UserWarning: Unable to load AWS_CREDENTIAL_FILE ()
I'm slightly surprised to be downloading something with
linux64
in its path on s390x, but I don't think this is new -- I think this is coming from https://github.com/nodejs/node/blob/90dea9e3e003945f113aaca09c45f963fe566a47/deps/v8/DEPS#L498-L509 and that isn't recent.
Although in v8-canary this appears to have been moved to linux64-format
in buildtools
:
https://chromium.googlesource.com/chromium/src/buildtools.git/+/19268125543e152a215808913dacafe77ecae63f/DEPS#58
hmm and now I'm not seeing the problem again on the CI 😕(🎉 ?). Will pick this up again on Monday.
All the weekend runs passed. Going to optimistically close.
Starting 2 August, node-test-commit-v8-linux has started to fail for rhel8-s390x.
e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6105/console
This only appears to be happening on rhel8-s390x -- the x64 and ppc64le builds are passing.