search

nodejs / build

Better build and test infra for Node.
506 stars 165 forks source link

'curl' is not recognized as an internal or external command #3934

Open richardlau opened 1 week ago

richardlau commented 1 week ago

Not sure if this is related to https://github.com/nodejs/build/issues/3929, but looking at the two most recent node-daily-v20.x-staging and node-daily-v18.x-staging runs, Windows test jobs on x86 are failing with e.g. https://ci.nodejs.org/job/node-test-binary-windows-js-suites/30833/RUN_SUBSET=0,nodes=win2016-COMPILED_BY-vs2019-x86/console

13:10:15 C:\workspace\node-test-binary-windows-js-suites>curl -LO https://raw.githubusercontent.com/nodejs/build/main/jenkins/scripts/windows/ci-run.cmd 
13:10:15 'curl' is not recognized as an internal or external command,
13:10:15 operable program or batch file.
13:10:15 
13:10:15 C:\workspace\node-test-binary-windows-js-suites>call ci-run.cmd node-test-binary-windows-js-suites 
13:10:15 'ci-run.cmd' is not recognized as an internal or external command,
13:10:15 operable program or batch file.
13:10:15

cc @StefanStojanovic

StefanStojanovic commented 1 week ago

Thanks for reporting this @richardlau I'll take a look today/tomorrow.

StefanStojanovic commented 1 week ago

Based on the build history, errors started after the update 2 days ago, but that update job didn't update anything, which is suspicious. Will continue the investigation later.

StefanStojanovic commented 6 days ago

The issue was that Windows Server 2016 machines don't have curl.exe inside their C:\Windows\System32 directory. They get it from Git\mingw64\bin which was removed from the path environment variable similarly to the Git\usr\bin after the downgrade I did last week. The machines are now updated and I'll close this issue on Friday if everything works fine.