search

nodejs / citgm

Canary in the Gold Mine
https://www.npmjs.com/package/citgm
Other
569 stars 148 forks source link

Support pnpm; add Next.js #1017

Open GeoffreyBooth opened 1 year ago

GeoffreyBooth commented 1 year ago

I’d like to add Next.js to CITGM. It uses pnpm to install dependencies, and before its tests can run it needs to be built. See https://github.com/vercel/next.js/blob/canary/contributing/core/developing.md.

Can we add support for pnpm like we do for yarn? And also another flag like build: true that when set runs <npm/yarn/pnpm> run build before running <npn/yarn/pnpm> test?

cc @Ethan-Arrowood

targos commented 1 year ago

pnpm: sure if someone contributes it Build script: already possible. You can provide an array of scripts to run.

Ethan-Arrowood commented 1 year ago

FYI I've made relative teams aware of this internally at Vercel. I'll do my best to facilitate someone to assist with adding Next.js once pnpm is supported.

Ethan-Arrowood commented 10 months ago

For cross reference, adding Next.js to CITGM will help deter events such as: https://github.com/nodejs/node/issues/50269

styfle commented 10 months ago

I created a PR here: https://github.com/nodejs/citgm/pull/1044