search

nodejs / citgm

Canary in the Gold Mine
https://www.npmjs.com/package/citgm
Other
569 stars 148 forks source link

v21.x failing modules #1033

Closed RafaelGSS closed 5 months ago

RafaelGSS commented 11 months ago

The last 3 runs failed on Node.js 21. I've run against v21.x just to confirm it's nothing related to the v21.3.0 proposal

Modules:

citgm.jest-v29.7.0 #1032 citgm.ember-cli-v5.4.1 - @stefanpenner, @rwjblue, @Turbo87, @kellyselden citgm.yeoman-generator-v7.1.1 - @SBoudrias, @sindresorhus citgm.nan-v2.18.0 - @nodejs/addon-api citgm.q-v1.5.1 - @kriskowal

ljharb commented 11 months ago

i believe maxogden → @max-mapper

arcanis commented 11 months ago

How can we check the logs? The @yarnpkg/cli logs seem unrelated to Yarn (ConnectTimeoutError: Connect Timeout Error), but perhaps I'm looking at the wrong place.

RafaelGSS commented 11 months ago

@arcanis some of them might be related to the machine, yeah. I just want to make sure these timeouts aren't flaky on yarnpkg/cli but something with our machine

The ci.nodejs.org links are the ones with logs.

novemberborn commented 11 months ago

AVA's failure is (most likely) a known issue, fixed in main but not yet released.

mourner commented 11 months ago

I tried looking into what might be the problem in binary-split, but it seems to work fine with Node v21.3. The logs for the failure above also says ConnectTimeoutError: Connect Timeout Error, so perhaps it's just a flaky test and not something that needs fixing?

RafaelGSS commented 11 months ago

Timeout errors are usually machine issues since we run tests in parallel and the CPU can get stale causing timeouts. If this persists we can reduce/remove the concurrency - but it might affect the time elapsed of CITGM, which is undesirable.

lpinca commented 11 months ago

The ws failure is the same and on the same platform for all runs. On macOS, that test also fails on GHA sometimes. I would prefer not to do it, but I think I can skip it on macOS.

RafaelGSS commented 11 months ago

I've just removed for the issue description the modules where the authors/maintainers confirmed the issues aren't related to the package itself. Thank you!

I'll wait maintainers' input for the other ones.

RafaelGSS commented 11 months ago

I've read all the lists again and removed the ones failing with timeout, which tends to be a machine issue and I've created a PR to skip the non-machine-related failing on Node.js 21. https://github.com/nodejs/citgm/pull/1035

RafaelGSS commented 10 months ago

Last v21.x run:

Failures:

RafaelGSS commented 5 months ago

Closing in favour of https://github.com/nodejs/citgm/issues/1060