search

nodejs / citgm

Canary in the Gold Mine
https://www.npmjs.com/package/citgm
Other
562 stars 147 forks source link

Skip AIX in undici, as esbuild does not run there #1068

Closed mcollina closed 2 months ago

richardlau commented 2 months ago

Skip AIX in undici, as esbuild does not run there

It should do, as of esbuild@0.19.10 (https://github.com/evanw/esbuild/issues/3549).

merceyz commented 2 months ago

And if that doesn't work, Undici could try using esbuild-wasm instead.

mcollina commented 2 months ago

Well, this failed: https://ci.nodejs.org/job/citgm-smoker/3465/nodes=aix72-ppc64/testReport/junit/(root)/citgm/undici_v6_19_2/.

richardlau commented 2 months ago

Well, this failed: https://ci.nodejs.org/job/citgm-smoker/3465/nodes=aix72-ppc64/testReport/junit/(root)/citgm/undici_v6_19_2/.

It's using an older esbuild (i.e. less than 0.19.10).

 > npx esbuild@0.19.4 index-fetch.js --bundle --platform=node --outfile=undici-fetch.js --define:esbuildDetection=1 --keep-names && node scripts/strip-comments.js
mcollina commented 2 months ago

Ah! Will update.