Open mcollina opened 5 years ago
Current list of express' direct dependencies:
{ accepts: '~1.3.5',
'array-flatten': '1.1.1',
'body-parser': '1.18.3',
'content-disposition': '0.5.2',
'content-type': '~1.0.4',
cookie: '0.3.1',
'cookie-signature': '1.0.6',
debug: '2.6.9',
depd: '~1.1.2',
encodeurl: '~1.0.2',
'escape-html': '~1.0.3',
etag: '~1.8.1',
finalhandler: '1.1.1',
fresh: '0.5.2',
'merge-descriptors': '1.0.1',
methods: '~1.1.2',
'on-finished': '~2.3.0',
parseurl: '~1.3.2',
'path-to-regexp': '0.1.7',
'proxy-addr': '~2.0.4',
qs: '6.5.2',
'range-parser': '~1.2.0',
'safe-buffer': '5.1.2',
send: '0.16.2',
'serve-static': '1.13.2',
setprototypeof: '1.1.0',
statuses: '~1.4.0',
'type-is': '~1.6.16',
'utils-merge': '1.0.1',
vary: '~1.1.2' }
Currently tested in citgm:
I already have an open PR for debug
in https://github.com/nodejs/citgm/pull/626
onFinished(res, listener) when response errors should fire with error
)Error: expected 404 "Not Found", got 400 "Bad Request"
at serveStatic() fallthrough when true should fall-through when URL too long
)I think we should start adding the passing ones immediately, and then add the other ones as soon as they pass.
Forked from https://github.com/nodejs/node/issues/24586#issuecomment-443229311.
It seems we are lacking quite a bit of testing.
cc @dougwilson