search

nodejs / citgm

Canary in the Gold Mine
https://www.npmjs.com/package/citgm
Other
569 stars 148 forks source link

Use pkgjs/action for CI to auto-upgrade to latest nodes #891

Open dominykas opened 2 years ago

dominykas commented 2 years ago

The CI workflow used here is almost identical to a standard Node.js library testing pattern (checkout, npm install, npm test).

As part of Package Maintenance WG, I've recently created pkgjs/action - it basically does that standard Node testing pattern, but it automatically maintains the test matrix for you, i.e. it will automatically detect the lowest supported (major) version from engines field and will automatically add new Node.js versions as they come out.

As the action is pretty new, I'd like to get some battle testing for it.

Would people mind if I opened a PR to start using it here? I'm willing to take on the maintenance of that until we feel it's stable.

The end result here would probably look something like this: https://github.com/nodejs/undici/blob/main/.github/workflows/nodejs.yml

Trott commented 2 years ago

@nodejs/citgm

BethGriggs commented 2 years ago

I was going to open a PR to remove Node.js 12 from the CI workflow, but then realised this would be a preferable approach (IMO).

+1 to doing this.

dominykas commented 2 years ago

Opened a #907, although I'm thinking if it is enough of an improvement if the same is not applied to the test-module workflow... and I need to think about whether a feature to check out an arbitrary repo via pkgjs/action makes sense... Maybe?