search

nodejs / citgm

Canary in the Gold Mine
https://www.npmjs.com/package/citgm
Other
568 stars 148 forks source link

pino@8.15.1 failures #988

Closed ruyadorno closed 11 months ago

ruyadorno commented 1 year ago

Hi @mcollina I noticed you're listed as maintainer for pino so I'd like to bring to your attention that pino@8.15.1 tests have been failing inconsistently across different systems on v20.x. Feel free to loop in more contributors that you think may help.

During the process of working on v20.8.0 I've observed it failing a bunch of times and it would be nice to have someone familiar with the code and its tests to take a look at what is possibly going on. Unfortunately I can't reproduce it locally on my macos machine so I have no more info to add.

Here are a few failed citgm runs for reference:

mcollina commented 1 year ago

I'll take a look asap. We are currently trying to nail down what behavior broke between v18 and v20 that causes all those.

ruyadorno commented 1 year ago

I'm going to mark pino as flaky while we wait for a solution here so that we can hopefully get a green citgm run in v18.x 🤞

mcollina commented 1 year ago

updated run that should fix the flaky test: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3305/

mcollina commented 1 year ago

I think this is fixed. Let me know if there is anything else here.