Code And Learn at NodeFest 2017

hiroppy commented 7 years ago

Hi!

We will hold NodeFest which is the largest Node.js conference in Japan. I’m one of the organizers this year. The team members are @yosuke-furukawa, @watilde, myself and some other great nodeschool staff.

We would like to open code-and-learn-jp on NodeFest and support the contribution to nodejs/core.

Please feel free to suggest any contribution areas for the participants! @nodejs/collaborators We will receive some PRs on 26th November.(http://nodefest.jp/2017/schedule.html)

/cc @yosuke-furukawa @watilde @nodejs/nodejs-ja

Thanks.

Mentors

@abouthiroppy
@yosuke-furukawa
@watilde
@joyeecheung
@ronkorving
@MylesBorins
... you?

joyeecheung commented 7 years ago

cc @Trott @addaleax

Also, I will be there. Happy to help out with whatever needed.

ronkorving commented 7 years ago

Of course I will be there 👍

vsemozhetbyt commented 7 years ago

Possible case in tests: https://github.com/nodejs/node/pull/16243#discussion_r145045432 + next comment: check else if by if replacements when a previous if contains return. Also check else eliminations on similar condition.

hiroppy commented 7 years ago

@vsemozhetbyt Thank you for your information!

watilde commented 7 years ago

Note: Here is the last time we had - https://github.com/nodejs/code-and-learn/issues/58

jasnell commented 7 years ago

This is awesome. Keep in mind that we're also running a small code-and-learn at NodeConf EU at the beginning of November so some of the tasks may adjust after that. We should likely coordinate a bit in advance to make sure we don't end up duplicating any effort! :-) (I totally wish I was able to get to Tokyo this year)

One possible set of tasks that I can suggest for new contributors who are bit more confident in their Node.js skills, would be converting tests to use the new ../common/countdown utility module.

For instance, if you take a look at: https://github.com/nodejs/node/blob/master/test/parallel/test-http2-client-destroy.js, you'll see that there is a remaining counter (https://github.com/nodejs/node/blob/master/test/parallel/test-http2-client-destroy.js#L19). The test then counts down remaining before closing the server. There are quite a large number of tests in our suite that perform similar actions in ways that are rather inconsistent. The ../common/countdown utility was designed to bring some consistency there.

The way the Countdown utility works is straightforward:

const common = require('../common');
const Countdown = require('../common/countdown');

// ...

const countdown = new Countdown(n, common.mustCall(() => {
  // do something here
}));

// Decrement the counter, the callback is called synchronously when
// countdown.dec is called n times.
countdown.dec();

I know that there are quite a few of the http2 tests that can benefit from this, along with a bunch of other http and https tests.

These tasks would be for folks who are a bit more comfortable with their Node.js skills.

apapirovski commented 7 years ago

Another potential suggestion is replacing assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); It's another thing I would like to ideally introduce an eslint rule for (already have it written) but there are currently a ton of instances where we use the former.

I think that's pretty similar in difficulty to the change that was done at Node.js Interactive this year.

AndreasMadsen commented 7 years ago

A simple thing is removing the redundant + from +conf.n in the benchmarks. If the values are integers in the bench(main, conf) object they will be integers in the main(conf) object too.

example: https://github.com/nodejs/node/blob/master/benchmark/assert/deepequal-object.js#L30L31

hiroppy commented 7 years ago

@jasnell @apapirovski @AndreasMadsen Thanks.🙌 I try to summarize that information in Gist.
You should come to Nodefest2017!!

MylesBorins commented 7 years ago

I can help!

Any interest in running a values session similar to what we did at node interactive?

On Oct 19, 2017 5:01 AM, "Yuta Hiroto" notifications@github.com wrote:

@jasnell https://github.com/jasnell @apapirovski https://github.com/apapirovski @AndreasMadsen https://github.com/andreasmadsen Thanks.🙌 I try to summarize that information in Gist. You should come to Nodefest2017!!

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/code-and-learn/issues/72#issuecomment-337845316, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecVwrKcRTYEduY19ofZjv5tBf_N2vsks5stw_XgaJpZM4P9VKJ .

apapirovski commented 7 years ago

@abouthiroppy For my suggestion above, I created a gist with an eslint rule that will let you find all instances of assert.throws(fn, common.expectsError(err));.

hiroppy commented 7 years ago

@MylesBorins Thanks!! yep, but I don't know the values session of node interactive. Would you give me this information?

@apapirovski wow, thank you so much 🙇 I'll use it!

seishun commented 7 years ago

I'm on the fence about attending (concerned about the cost mostly).

fhinkel commented 6 years ago

Also, I will be there. Happy to help out with whatever needed.

hiroppy commented 6 years ago

Sorry for my late reply.

@seishun I think that Node.js Foundation will help with the cost. @fhinkel Thanks!

Trott commented 6 years ago

@seishun I think that Node.js Foundation will help with the cost.

I don't think the foundation typically sends Collaborators to an event simply because it's a Node.js event. It's usually a Collaborator Summit. There have been some exceptions though, like sending particular people to a TC-39 meeting one time.

That said, there's absolutely nothing stopping any Collaborator from requesting funds from the TSC for something by opening an issue in the TSC repository.

MylesBorins commented 6 years ago

Have we prepared a list of changes for participants to implement?

How many people are we expecting?

yosuke-furukawa commented 6 years ago

I guess 30 - 50 people.

yosuke-furukawa commented 6 years ago

Have we prepared a list of changes for participants to implement? Not yet !! I will create the list asap...

MylesBorins commented 6 years ago

I can help collect some changes after I run the Taiwan code and learn

On Nov 20, 2017 4:53 AM, "Yosuke Furukawa" notifications@github.com wrote:

Have we prepared a list of changes for participants to implement? Not yet !! I will create the list asap...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345645203, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecV2P7RIvNo1FfAQ8eK5A-sJwbyhLpks5s4UwQgaJpZM4P9VKJ .

hiroppy commented 6 years ago