search

nodejs / code-and-learn

A series of workshop sprints for Node.js.
164 stars 79 forks source link

Tel Aviv Nov 20th #75

Closed benjamingr closed 7 years ago

benjamingr commented 7 years ago

I'll be onboarding (hopefully) around 8 people in Tel Aviv as a part of an open source event we've been doing monthly in the last few months.

If anyone is around by any chance and wants to help - any help is appreciated :)

Trott commented 7 years ago

Only other Collaborator I'm aware of in Israel is @jhamhader.

benjamingr commented 7 years ago

@Trott me too - but people travel and I was hoping someone might be around :)

Trott commented 7 years ago

but people travel and I was hoping someone might be around

Oh, sure, I just was taking the opportunity to ping them by name, that's all. :-D

benjamingr commented 7 years ago

Anyone has any interesting ideas for PRs for tomorrow? the good-first-issue tag is a little lacking at the moment :)

Trott commented 7 years ago

the good-first-issue tag is a little lacking at the moment :)

AFAICT, it's always lacking. If something is legitimately a good first issue, someone or multiple someones do it within a day or two, often within an hour or two. Otherwise, it's a good first issue for someone with a very specific set of skills.

Hopefully @MylesBorins wasn't going to use these for C+L Taiwan this week, but there are two tests still using common.fixturesDir so replacing that would be tasks for two people. Then a third task (after those first two land) could be to remove common.fixturesDir from test/common/index.js and test/common/README.md?

Trott commented 7 years ago

This probably isn't a change for Node.js core but rather a change for tooling around Node.js core, but if that's fine then maybe: Find the tooling for making the changelog and change things that say "semver-major" to "breaking changes" and "semver-minor" to "new features"? Or at least do that for section headings like https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V9.md#semver-major if not the individual commits in that section?

MylesBorins commented 7 years ago

We use changelog maker for generating changelogs

Seems like that would be where that would need to be implemented Rich

On Nov 19, 2017 1:57 PM, "Rich Trott" notifications@github.com wrote:

This may be a bit much for a first contribution and/or probably isn't a change for Node.js core but rather a change for tooling around Node.js core, but if that's fine then maybe: Find the tooling for making the changelog and change things that say "semver-major" to breaking changes and "semver-minor" to new features? Or at least do that for section headings like https://github.com/nodejs/node/blob/master/doc/ changelogs/CHANGELOG_V9.md#semver-major if not the individual commits in that section?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/code-and-learn/issues/75#issuecomment-345540557, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecVwjVVYahzJyUKLgFagO1htHSjW-eks5s4HoNgaJpZM4QTRY7 .

MylesBorins commented 7 years ago

Closing as the 20th has already happened!

@benjamingr how'd it go?

benjamingr commented 7 years ago

Went pretty well - translated to 5 PRs and people seemed enthusiastic. I'll report back next month and see who showed up again.