search

nodejs / corepack

Zero-runtime-dependency package acting as bridge between Node projects and their package managers
MIT License
2.57k stars 169 forks source link

Refactoring of the CLI interface #291

Closed arcanis closed 1 year ago

arcanis commented 1 year ago

This PR is the first step towards implementing the changes from https://github.com/nodejs/corepack/issues/274

I added tests for use and up since those are new; install and pack should already covered by the existing tests, which I migrated from prepare / hydrate to the new commands.

The old commands are still there, but I removed their help messages so they don't appear in corepack -h anymore.

arcanis commented 1 year ago

No idea why Node.js 20.0 seems unable to use the Nock files from 16.x, but only on Windows 🤔 I think I'll just remove the 16.x tests, since it's EOL on Sep 11 anyway ...

Edit: Actually it worked after a restart - I think a timeout caused some requests to not run, which messed with how Nock answers the http requests.

styfle commented 1 year ago

The old commands are still there

Thanks for keeping those! That will help as we migrate support for multiple versions of corepack 👍

arcanis commented 1 year ago

Should be good to merge.