search

nodejs / corepack

Zero-runtime-dependency package acting as bridge between Node projects and their package managers
MIT License
2.36k stars 150 forks source link

fix: use valid semver range for `engines.node` #378

Closed merceyz closed 5 months ago

merceyz commented 5 months ago

The range added in https://github.com/nodejs/corepack/pull/375 isn't valid.

merceyz commented 5 months ago

@aduh95 I don't think merging a PR without review after just 10 minutes is something we should be doing.

styfle commented 5 months ago

How about adding a test too, to confirm this works as expected?

arcanis commented 5 months ago

Rather than a test Yarn should probably natively validate that those fields are proper ranges.