search

nodejs / corepack

Zero-runtime-dependency package acting as bridge between Node projects and their package managers
MIT License
2.36k stars 150 forks source link

fix: do not hard fail if Corepack home folder cannot be created #382

Closed aduh95 closed 5 months ago

aduh95 commented 5 months ago

Fixes: https://github.com/nodejs/corepack/issues/379

aduh95 commented 5 months ago

The reason the tests didn't catch it is because we specifically disable it: https://github.com/nodejs/corepack/blob/4a8ce6d42f081047a341f36067696346c9f3e1ea/tests/main.test.ts#L14

If we re-enable it, it will cause the nock to be outdated as soon as Yarn publish a new version (if we use yarn -v) which is not ideal.