search

nodejs / corepack

Zero-runtime-dependency package acting as bridge between Node projects and their package managers
MIT License
2.31k stars 146 forks source link

Adds a warning when using npm through Corepack #407

Closed arcanis closed 4 months ago

arcanis commented 4 months ago

The Corepack team always made it clear that enabling npm support in Corepack was contingent on the npm team being supportive of this effort.

The npm team mentioned in https://github.com/nodejs/node/issues/50963#issuecomment-1897097892 that they are welcoming of other package managers being shipped with Node througn Corepack, but don't wish npm to be distributed this way. That's entirely their right, we made sure that this project wouldn't have any impact on npm unless they wished it.

Still, since some people are getting fired up about what could have been but won't be, perhaps we should go one step further. This PR removes any mention of npm support from the README (adding it as a non-goal instead), and adds an additional warning to the prompt when npm would otherwise be downloaded.

arcanis commented 4 months ago

Alternatively, perhaps we could just extend the README to remove the npm references, explain there that supporting npm is a non-goal and provided on a best effort basis, and perhaps add an additional message on the prompt line to mention it there as well.

Edit: That's what I did, it feels a less risky change.

GeoffreyBooth commented 4 months ago

One of Corepack’s goal is to provide a levelled playing field

Where is this defined?