search

nodejs / corepack

Zero-runtime-dependency package acting as bridge between Node projects and their package managers
MIT License
2.31k stars 146 forks source link

feat: update package manager versions #425

Closed github-actions[bot] closed 2 months ago

github-actions[bot] commented 3 months ago

This is an automated update of package manager versions

merceyz commented 3 months ago

We should fix the CI so we don't have to close and re-open these pull requests to get the CI to run.

arcanis commented 3 months ago 
Internal Error: Error when performing the request to https://registry.yarnpkg.com/yarn/-/yarn-1.22.22.tgz; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting

We also really should improve this error message, it's very generic.

Given that all tests are failing, perhaps there's a GitHub Actions incident?

merceyz commented 3 months ago

That error has a cause property that contains more details but Clipanion isn't showing it, reported upstream in https://github.com/arcanis/clipanion/issues/157. Though we don't need to go through Clipanion here so we could remove it from the flow.

Given that all tests are failing, perhaps there's a GitHub Actions incident?

They're not anymore, the nocks needed to be updated.

aduh95 commented 3 months ago

We should fix the CI so we don't have to close and re-open these pull requests to get the CI to run.

I don't think it's fixable, see https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN […] will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs.

merceyz commented 3 months ago

If we use a Personal Access Token or a deploy key the CI will run.