chore: use `pipeline` from `node:stream/promises`

nodejs / corepack

Zero-runtime-dependency package acting as bridge between Node projects and their package managers

MIT License

2.31k stars 146 forks source link

chore: use `pipeline` from `node:stream/promises` #441

Closed aduh95 closed 3 months ago

aduh95 commented 3 months ago

Because Corepack predates the Stream Promise API, the code was using once(stream, 'finish'), which is arguably not as self-explanatory as pipeline() API.

aduh95 commented 3 months ago

There are a few tests falling, and it looks like this is going to conflict with https://github.com/nodejs/corepack/pull/439. Giving up for now.