nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.28k stars 1.97k forks source link

arm32v6 Architecture Missing `lts` and `18` #1963

Open scottschreckengaust opened 1 year ago

scottschreckengaust commented 1 year ago

Problem

The official node images are missing the lts and 18 tags for the arm32v6 architecture https://hub.docker.com/r/arm32v6/node/:

% docker pull arm32v6/node:lts
Error response from daemon: manifest for arm32v6/node:lts not found: manifest unknown: manifest unknown

% docker pull arm32v6/node:18
Error response from daemon: manifest for arm32v6/node:18 not found: manifest unknown: manifest unknown

arm32v6 is not consistent with the other five supported architectures. See lines in https://github.com/nodejs/docker-node/blob/main/architectures

bashbrew-arch  variants
amd64          alpine3.17,alpine3.18,bookworm,bookworm-slim,bullseye,bullseye-slim,buster,buster-slim
arm32v6        alpine3.17,alpine3.18
arm32v7        alpine3.17,alpine3.18,bookworm,bookworm-slim,bullseye,bullseye-slim,buster,buster-slim
arm64v8        alpine3.17,alpine3.18,bookworm,bookworm-slim,bullseye,bullseye-slim,buster,buster-slim
i386           alpine3.17,alpine3.18
ppc64le        alpine3.17,alpine3.18,bookworm,bookworm-slim,bullseye,bullseye-slim,buster,buster-slim
s390x          alpine3.17,alpine3.18,bookworm,bookworm-slim,bullseye,bullseye-slim,buster,buster-slim

Solution

Mimic the other five documented supporting architectures (amd64, arm32v7, arm64v8,ppc64le, and s390x)

% docker pull arm32v6/node:lts
lts: Pulling from arm32v6/node
...

% docker pull arm32v6/node:18
18: Pulling from arm32v6/node
...

Alternatives to Consider

scottschreckengaust commented 1 year ago

I am aware of the arm32v6/node:lts-alpine, but this is not the same. Also, https://github.com/docker-library/official-images/blob/master/library/node would likely need an update...

nschonni commented 1 year ago

LTS and 18 are aliases to the Debian base images, which no longer support that architecture. ARM32v7 also no longer successfully builds on those platforms and is likely to be dropped https://github.com/nodejs/docker-node/pull/1886