search

nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.27k stars 1.97k forks source link

feat: Node.js 18.19.0, 21.3.0 #2002

Closed knksmith57 closed 11 months ago

knksmith57 commented 11 months ago

Description

Followed https://github.com/nodejs/docker-node/blob/main/CONTRIBUTING.md

Builds images for https://github.com/nodejs/node/pull/50953

knksmith57 commented 11 months ago

Note: it doesn't look like update.sh is correctly handling the alpine image updates due to a failing checksum fetch for 18.x

❯ ./update.sh alpine
Updating version 18...
Updating version 20...
Updating version 21...
18/bookworm/Dockerfile is already up to date!
20/bookworm/Dockerfile is already up to date!
18/bullseye-slim/Dockerfile is already up to date!
18/bullseye/Dockerfile is already up to date!
18/buster-slim/Dockerfile is already up to date!
18/buster/Dockerfile is already up to date!
18/bookworm-slim/Dockerfile is already up to date!
20/buster/Dockerfile is already up to date!
20/bullseye/Dockerfile is already up to date!
**********
Fatal Error: Failed to fetch checksum for version 18.19.0
**********
20/bookworm-slim/Dockerfile is already up to date!
**********
Fatal Error: Failed to fetch checksum for version 18.19.0
**********
20/bullseye-slim/Dockerfile is already up to date!
20/alpine3.18/Dockerfile is already up to date!
20/buster-slim/Dockerfile is already up to date!
20/alpine3.17/Dockerfile is already up to date!
21/bookworm/Dockerfile is already up to date!
21/bookworm-slim/Dockerfile is already up to date!
21/bullseye/Dockerfile is already up to date!
21/bullseye-slim/Dockerfile is already up to date!
21/alpine3.17/Dockerfile is already up to date!
21/alpine3.18/Dockerfile is already up to date!
Done!
knksmith57 commented 11 months ago

Looks like the checksum file for 18.19.0 is missing on unofficial-builds.nodejs.org: https://unofficial-builds.nodejs.org/download/release/v18.19.0/SHASUMS256.txt

knksmith57 commented 11 months ago

Filed https://github.com/nodejs/node/issues/50997. It turns out all release artifacts for 18.19.0 for alpine are missing.

https://unofficial-builds.nodejs.org/download/release/v18.19.0/

knksmith57 commented 11 months ago

@richardlau has requeued the 18.19.0 release build for us 🙏: https://github.com/nodejs/node/issues/50997#issuecomment-1836498548

knksmith57 commented 11 months ago

OK, alpine images are updated and things look good 💯

This is ready for review 🙏

knksmith57 commented 11 months ago

nvm, this is obviated by https://github.com/nodejs/docker-node/pull/2003