nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.13k stars 1.95k forks source link

Add Alpine 3.19 variant #2007

Closed jnoordsij closed 6 months ago

jnoordsij commented 6 months ago

Description

This PR adds a variant for Alpine 3.19 and drops the 3.17 variant at the same time. See also #1895.

Motivation and Context

Provide latest Alpine version (see https://alpinelinux.org/posts/Alpine-3.19.0-released.html).

Testing Details

Example Output(if appropriate)

Types of changes

Checklist

Note: the Alpine 3.19 base Docker image is yet to appear here, so automated checks will fail up till then; see also https://github.com/docker-library/official-images/pull/15852.

Edit: the Alpine 3.19 base images are now available, so this is now ready for a retrigger of the workflow!

SimenB commented 6 months ago

we need to wait for https://github.com/docker-library/official-images/pull/15852

Earlopain commented 6 months ago

Already merged.

github-actions[bot] commented 6 months ago

Created PR on the official-images repo (https://github.com/docker-library/official-images/pull/15876). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

wbecker commented 6 months ago

This seems to have broken my builds - node-gyp can't find python anymore. I'll downgrade and test...

Assuming its this though, as builds worked yesterday, before it was available and seems to have died today

wbecker commented 6 months ago

I can confirm that sticking to a previous tag here fixes the build.

nschonni commented 6 months ago

@wbecker we've never shipped python with Alpine https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#node-gyp-alpine

wbecker commented 6 months ago

Thanks - I'll try this! However there seems to be some issues with some libs - I'll link the issue here: https://github.com/nodejs/docker-node/pull/2009