nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.13k stars 1.95k forks source link

Node 20.10 to 20.11 regression using stream readables, discovered using google cloud sdk #2023

Closed UncleFirefox closed 5 months ago

UncleFirefox commented 5 months ago

Environment

Expected Behavior

Stream readables work without issues (detected using google cloud)

Current Behavior

Posted a question in stack overflow: https://stackoverflow.com/questions/77872930/google-cloud-bucket-file-download-nodejs-file-exists-but-readable-throws-erro In a nutshell: We had a regression using google cloud sdk, suddenly some functionalities reading files in google buckets failed from one day to the other without any aparent code changes. Turns out the change from node 20.10 to 20.11 on January 10th has introduced something which breaks stream readables under certain conditions, producing a very ugly express server restart. Rolling back to node:20.10.0 image solved the issue Expressjs using readables against google buckets breaks the server forcing a restart

Possible Solution

Steps to Reproduce

Additional Information

nschonni commented 5 months ago

Maybe something in the release is related to this https://nodejs.org/en/blog/release/v20.11.0, but no change in this repo would resolve this so you need to figure out an upstream reproduction