nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.24k stars 1.97k forks source link

Add Node debian core variant #2058

Open LaurentGoderre opened 6 months ago

LaurentGoderre commented 6 months ago

Add debian core variant without npm or yarn

Checklist

LaurentGoderre commented 5 months ago

Note to reviewer, only check the top commit since the other one is the security update. I rebased on top of it to validate it would work when the base image (the slim variant) didn't already exist.

PeterDaveHello commented 5 months ago

Do we also need an opinion from @tianon?

hulkish commented 5 months ago

would really like to see an alpine version of this without npm or yarn

tianon commented 5 months ago

"slim" is already an established convention in official images (with some slight variance for whether it's "FROM slim" or a slimmed image itself), but "core" is not, so I wonder if "core" is already established nomenclature in Node.js communities?

Also, I think it's probably worth updating the templating to not copy docker-entrypoint.sh (which is copied from the "donor" image, not from the build context).

LaurentGoderre commented 5 months ago

We are but painted into a corner because slim already contain package manager so we need a different name.

Why not copy the entry point? Do you think it's better to copy from file?

tianon commented 5 months ago

Well, the Dockerfile as written is already copying the entrypoint from the donor image (which is fine, I think), so having it in the build context again is unnecessary and just makes the diff larger without a real purpose. :smile:

LaurentGoderre commented 5 months ago

Fixed