search

nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.13k stars 1.95k forks source link

Update yarn version to 1.22.22 #2064

Closed markedwards closed 2 months ago

markedwards commented 2 months ago

Problem

yarn v1.22.22 has bug fixes. Shouldn't the version in the base images be bumped?

Solution

ENV YARN_VERSION 1.22.19

Alternatives to Consider

LaurentGoderre commented 2 months ago

Yarn 1.22.22 is unfortunately not stable yet.

markedwards commented 2 months ago

Yeah, realized that after posting.

So, just to be clear, whatever version is marked as stable ends up getting bumped in the dockerfiles?

Thanks.

SimenB commented 2 months ago

So, just to be clear, whatever version is marked as stable ends up getting bumped in the dockerfiles?

yes, what https://yarnpkg.com/latest-version returns is used

markedwards commented 2 months ago

Thanks for the clarification everyone.

Daniel15 commented 1 month ago

I've uploaded a GPG signature for Yarn v1.22.22, along with all other missing artifacts (.deb, .rpm, and Windows installer), and the website now lists v1.22.22 as stable. This should be good to update now.

nschonni commented 1 month ago

Note that the update script will only bump the Yarn version when there is also a Node.js version change. I did confirm that if I changed one of the version numbers and re-ran the update.sh, it did pick up the new version. Be patient, and it'll be picked up on the next Node.js releases ;)

nschonni commented 1 month ago

Node 20 will have the new Yarn once the upstream PR lands from https://github.com/nodejs/docker-node/pull/2089