nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.13k stars 1.95k forks source link

Pin markdown-link-check to v3.11.0 on GitHub Actions #2067

Closed PeterDaveHello closed 2 months ago

PeterDaveHello commented 2 months ago

Description

Pin markdown-link-check to v3.11.0 in the GitHub Actions workflow to avoid incorrect 404 errors on existing section links.

Motivation and Context

Starting from markdown-link-check v3.12.1, there is a bug where it incorrectly reports 404 errors for valid existing section links in Markdown files, while v3.11.2 and older do not have this issue, as seen in the CI log:

https://github.com/nodejs/docker-node/actions/runs/8650084895/job/23717794438?pr=2066

To ensure our CI continues to function correctly without these false positive 404 errors, this PR pins the markdown-link-check version to v3.11.0 in the GitHub Actions workflow file.

Testing Details

The changes in this PR were tested by running the updated GitHub Actions workflow on a test branch. The previously occurring false positive 404 errors no longer appear after pinning markdown-link-check to v3.11.0.

Types of changes

Checklist