search

nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.13k stars 1.95k forks source link

Revert "Hide auto-generated files in code reviews and format Dockerfile templates" #2070

Closed nschonni closed 1 month ago

nschonni commented 2 months ago

Reverts nodejs/docker-node#2062

This means we need to click the "load diff" everywhere in the UI including the Commit view to see the actual changes. These files may be auto-generated in some cases, but we we need to verify the changes visually to ensure there are no intentional or unintentional malicious changes.

PeterDaveHello commented 1 month ago

This is definitely why we should make the PR and commit clean so that it'll be much more easier to trace, revert, etc.