nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.13k stars 1.95k forks source link

feat: Node.js 22.0.0 #2071

Closed AbhiPrasad closed 2 months ago

AbhiPrasad commented 2 months ago

Description

Release for Node.js 22.0.0: https://nodejs.org/en/blog/release/v22.0.0

Based on https://github.com/nodejs/docker-node/pull/1882 and https://github.com/nodejs/docker-node/pull/1980

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

Checklist

nschonni commented 2 months ago

Thanks for doing this! It looks like you already caught the chmod for the scripts too. Once the the Alpine images are available in https://unofficial-builds.nodejs.org/download/release/v22.0.0/, please re-update this and squash it down to a single commit

AbhiPrasad commented 2 months ago

Once the the Alpine images are available

How long does this usually take?

nschonni commented 2 months ago

Sometimes an hour or so, but I think it ran into a problem, so I opened https://github.com/nodejs/unofficial-builds/issues/141

SimenB commented 2 months ago

Musl builds are there now, so please update the PR 🙂

AbhiPrasad commented 2 months ago

Squashed and pushed up the changes!

SimenB commented 2 months ago

The checksum is wrong? Did you use the update script to poll it? Running it gives me this diff

diff --git i/22/alpine3.18/Dockerfile w/22/alpine3.18/Dockerfile
index cec5d46..21fddbb 100644
--- i/22/alpine3.18/Dockerfile
+++ w/22/alpine3.18/Dockerfile
@@ -10,7 +10,7 @@ RUN addgroup -g 1000 node \
         curl \
     && ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
       && case "${alpineArch##*-}" in \
-        x86_64) ARCH='x64' CHECKSUM="d33e48f25ba714a69c920c584710892f4a77dce90c9bba23a228c5c1136f7a53" OPENSSL_ARCH=linux-x86_64;; \
+        x86_64) ARCH='x64' CHECKSUM="0687dddb3a69d61951e102b7a31bb8e20398614665e020a415ad6908316b308a" OPENSSL_ARCH=linux-x86_64;; \
         x86) OPENSSL_ARCH=linux-elf;; \
         aarch64) OPENSSL_ARCH=linux-aarch64;; \
         arm*) OPENSSL_ARCH=linux-armv4;; \
diff --git i/22/alpine3.19/Dockerfile w/22/alpine3.19/Dockerfile
index 6900e91..d79a458 100644
--- i/22/alpine3.19/Dockerfile
+++ w/22/alpine3.19/Dockerfile
@@ -10,7 +10,7 @@ RUN addgroup -g 1000 node \
         curl \
     && ARCH= OPENSSL_ARCH='linux*' && alpineArch="$(apk --print-arch)" \
       && case "${alpineArch##*-}" in \
-        x86_64) ARCH='x64' CHECKSUM="d33e48f25ba714a69c920c584710892f4a77dce90c9bba23a228c5c1136f7a53" OPENSSL_ARCH=linux-x86_64;; \
+        x86_64) ARCH='x64' CHECKSUM="0687dddb3a69d61951e102b7a31bb8e20398614665e020a415ad6908316b308a" OPENSSL_ARCH=linux-x86_64;; \
         x86) OPENSSL_ARCH=linux-elf;; \
         aarch64) OPENSSL_ARCH=linux-aarch64;; \
         arm*) OPENSSL_ARCH=linux-armv4;; \
AbhiPrasad commented 2 months ago

I had updated the checksums based on what was provided in https://nodejs.org/en/blog/release/v22.0.0 - but I see now the value provided in the script is different - updated!

SimenB commented 2 months ago

Alpine shasums are from https://unofficial-builds.nodejs.org/download/release/v22.0.0/

github-actions[bot] commented 2 months ago

Created PR on the official-images repo (https://github.com/docker-library/official-images/pull/16663). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.