nodejs / docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:
https://hub.docker.com/_/node/
MIT License
8.26k stars 1.97k forks source link

Add Jenkins/Build Badge for upstream official image status #2093

Open nschonni opened 5 months ago

nschonni commented 5 months ago

Problem

We often have people ask when why images or architectures are missing

Solution

Add a build badge or badges to the Official Images jenkins status of the Node.js jobs

Alternatives to Consider

Maybe having the build badges on the README would be confusing, because that date might end up on the Docker Hub, and maybe pointing to the links from the Issue Template picker might work instead.

/cc @yosifkit @LaurentGoderre

yosifkit commented 5 months ago

The current builds of node could work like we have in our repos: https://github.com/docker-library/golang/#:~:text=images%20repository.-,Build,-Status. But we are actively in the process of migrating to a new way of building that is no longer repo job based and so those links would be misleading (or broken) once we move node to the new build system.

The new build system is a bit more complex as there isn't one view of a repo anymore; it is all just architecture based (and complicated by some arches being a Github Actions yml that is triggered by Jenkins). Feel free to explore here: https://doi-janky.infosiftr.net/job/wip/job/new/; it is still a bit in flux.

Rough flow of jobs:

nschonni commented 5 months ago

Thanks! I think we can keep this one open and wait for your new system to be implemented. I guess the other place that it could be posted to is the comment that is left after an upstream PR is created https://github.com/nodejs/docker-node/blob/main/.github/workflows/official-pr.yml