Automate PR for removing EOL Node.js versions

nschonni commented 3 weeks ago

Problem

While doing https://github.com/nodejs/docker-node/pull/2100, I realized that our data is probably structured well enough that these PRs could be automated.

Solution

Create a (daily?) CI that:

Query the version.json for "end" <= Today
Delete the EOL node in version.json
Delete any version folders that are no longer in version.json
Create PR if there is diff

This could probably use https://github.com/nodejs/docker-node/blob/main/.github/workflows/automatic-updates.yml as an example, but probably should be it's own job.

Alternatives to Consider

This happens so infrequently that we don't want to bother automating

LaurentGoderre commented 3 weeks ago

I think how infrequent and how little change it is, I would vote to not do this. It could prevent cases where the dates change last minute and aren't update here.

SimenB commented 2 weeks ago

The release schedule exists as a JSON file - we should probably use data from that rather than duplicate its info into our own versions.json file.

https://github.com/nodejs/Release/blob/main/schedule.json

Then we at least won't have stale data to compare to

nodejs / docker-node