nodejs / email

MX server management for iojs.org (and eventually nodejs.org)
MIT License
61 stars 77 forks source link

fix: credentials.json is currently ignored in iojs.org folder #221

Closed UlisesGascon closed 1 year ago

UlisesGascon commented 1 year ago

currently the credentials are stored in iojs.org/credentials.json. This prevent accidental commit them.

richardlau commented 1 year ago

That's odd -- the file is ignored for me without this change:

$ git rev-parse HEAD
1e1305a7b3d247e8c7335cb2182bb83273946a09
$ cat .gitignore
credentials.json
node_modules
$ git status --ignored
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        update/package-lock.json

Ignored files:
  (use "git add -f <file>..." to include in what will be committed)
        iojs.org/credentials.json
        update/node_modules/

nothing added to commit but untracked files present (use "git add" to track)
$
Trott commented 1 year ago

Confirming what Richard wrote. The entry as it exists now should ignore credentials.json in all subdirectories so this change shouldn't be necessary. The git docs confirm that foo and **/foo will give the same result in a .gitignore file.

UlisesGascon commented 1 year ago

My fault, I made a mistake when I created the file name so that explains why the gitignore didn't act as I expected. Thanks for the review :)