nodejs / full-icu-npm

convenience loader for 'small-icu' node builds
https://nodejs.org/api/intl.html#intl_providing_icu_data_at_runtime
Other
152 stars 31 forks source link

postinstall.js does not exit #33

Closed Huulivoide closed 5 years ago

Huulivoide commented 5 years ago

postinstall.js file begins by checking for known "will not work" conditions and printing an error message on the console all which end in 'Exiting.' But the script does not exit. Instead it keeps on going until it fails.

My case: Archlinux upgraded the system ICU to version 64. Node on Arch is compiled with system-icu → postinstall notices node is using system icu, but still continues on and tries to install icu4c-data@64l resulting in failure to install the package.

eagleflo commented 5 years ago

I also encountered this on Arch Linux with Node v11.14.

srl295 commented 5 years ago

fixed in #34 via a632e50ae10ce25152830d296b06256cf81449a1