search

nodejs / github-bot

@nodejs-github-bot's heart and soul
MIT License
266 stars 116 forks source link

Could our github-bot create PR to homebrew-core ? #233

Open ZYSzys opened 5 years ago

ZYSzys commented 5 years ago

I found our github-bot create PRs to docker-library/official-images, so wondering could he also create PRs to homebrew-core ?

Then maybe we can access the latest Node.js from homebrew more quickly.

Screen Shot 2019-05-06 at 10 16 23 PM

phillipj commented 5 years ago

That trick is kind of an illusion so to speak, as it's actually Travis CI who does everything in the docker-node example you showed above. The only thing related to the github-bot, is an GitHub API token which allows Travis CI to open PRs from the github-bot account -- does that make sense?

For clarity, I'm surely not negative to the idea your proposing, I just wanted to shed some light on how the docker-node example actually works.

Refs https://github.com/nodejs/docker-node/pull/672 Refs https://github.com/nodejs/docker-node/issues/670