search

nodejs / github-bot

@nodejs-github-bot's heart and soul
MIT License
267 stars 119 forks source link

GitHub bot commenting on wrong repository if different than nodejs/node #262

Open mmarchini opened 4 years ago

mmarchini commented 4 years ago

Started a Jenkins CI for https://github.com/nodejs/node-auto-test/pull/19, the bot commented on https://github.com/nodejs/node/issues/19#issuecomment-650532924.

richardlau commented 4 years ago

This is (mainly) a build issue. See https://github.com/nodejs/build/issues/2166#issuecomment-539711522. It will involve updating every node-test-commit-* job to pass the REPO parameter through to the pipeline that triggers the bot.

(As an aside, I think the bot is hardcoded to use the nodejs org: https://github.com/nodejs/github-bot/blob/b5904f9a624300fb36f42ef12779f8591aba5490/scripts/jenkins-status.js#L46)

mmarchini commented 4 years ago

The bot expects the repo parameter, so we should probably do it (although for the comment maybe only node-test-pull-request needs updating?). There's no easy way to update those jobs, right?