search

nodejs / github-bot

@nodejs-github-bot's heart and soul
MIT License
270 stars 119 forks source link

doc: document how to apply a token with github-nodejs-bot #538

Closed legendecas closed 4 months ago

legendecas commented 4 months ago

Document how to apply a fine-grained token with github-nodejs-bot's name.

After this landed, github-nodejs-bot tokens that are not fine-grained tokens like https://github.com/nodejs/docker-node/blob/main/.github/workflows/automatic-updates.yml#L28 may be updated to be fine-grained tokens.

richardlau commented 4 months ago

I don't think this document belongs here -- this repository is for the code running the bot server and not for the bot user. I think https://github.com/nodejs/admin/ would be a better place for this.

legendecas commented 4 months ago

Well, this repo has the slogan of "@nodejs-github-bot's heart and soul" and the tokens are going to be used under the name of @nodejs-github-bot so I thought it would be easier to navigate here. And https://github.com/nodejs/admin/ is suitable for org-level requests, like creating a repo.

richardlau commented 4 months ago

And https://github.com/nodejs/admin/ is suitable for org-level requests, like creating a repo.

I consider requesting a new token to be an org-level request. Maintaining the registry of tokens is certainly more the responsibility of the TSC rather than the github-bot team that maintains this repository. If the tokens are primarily for publishing to e.g. the npm registry, then arguably it's similar documentation to https://github.com/nodejs/admin/blob/main/npm-management.md.

legendecas commented 4 months ago

Make sense. Closing in favor of https://github.com/nodejs/admin/pull/894.