search

nodejs / github-bot

@nodejs-github-bot's heart and soul
MIT License
270 stars 119 forks source link

refactor: migrate to ESM #542

Closed targos closed 3 months ago

Trott commented 4 months ago

LGTM. Is there a case to be made for landing https://github.com/nodejs/github-bot/pull/541 first, since it's a smaller/more focused change?

targos commented 3 months ago

LGTM. Is there a case to be made for landing #541 first, since it's a smaller/more focused change?

That PR is only useful if we don't migrate to ESM, so I think not (unfortunately). But feel free to merge it if you'd like to acknowledge the contribution and I'll add a revert commit to this PR.