chore: update release-please action - Githubissues

nodejs / gyp-next

A fork of the GYP build system for use in the Node.js projects

BSD 3-Clause "New" or "Revised" License

125 stars 69 forks source link

chore: update release-please action #168

Closed targos closed 1 year ago

targos commented 1 year ago

Hopefully it will work better, see https://github.com/nodejs/gyp-next/pull/167

cclauss commented 1 year ago

I doubt that version-file: pylib/gyp/__init__.py will work but worth a try...

https://github.com/google-github-actions/release-please-action#configuration

targos commented 1 year ago

By looking at https://github.com/googleapis/release-please/blob/dd78a70688747054a755801df69d5ce3a2ca0f07/src/strategies/python.ts#L80-L117 I think the solution is either to create a pyproject.toml or set component: gyp in the workflow.

targos commented 1 year ago

The problem being that the project is called gyp-next, but the code is still located in pylib/gyp

cclauss commented 1 year ago

So, is it:

[ ] component: gyp
[ ] component: gyp-next
[ ] component: pylib/gyp
[ ] component: pylib.gyp
[ ] component: pylib-gyp
[ ] component: pylib_gyp

I will try to convert to pyproject.toml

gengjiawen commented 1 year ago

If this still not work, we can patch the version automatically, see https://github.com/gengjiawen/monkey-rust/blob/35485ce9c5f596cd1982a1be53f84a2edbefdd2b/.github/workflows/prepare-release.yml#L12