search

nodejs / gyp-next

A fork of the GYP build system for use in the Node.js projects
BSD 3-Clause "New" or "Revised" License
125 stars 69 forks source link

Build failure due to spaces in path #180

Open recrsn opened 1 year ago

recrsn commented 1 year ago

When installing a native module using node-gyp, commands fail to run if there is a space in the path anywhere of the CWD.

A CWD like /home/abc/My Awesome Repo/project will fail.

This has been discussed here: https://github.com/kelektiv/node.bcrypt.js/issues/961 and here: https://github.com/nodejs/node-gyp/issues/65

And has been found to be an underlying issue with gyp itself

recrsn commented 1 year ago

There is also a potential fix here: https://github.com/nodejs/node-gyp/pull/2556

but the PR targets the vendored gyp code in node-gyp. It should belong here