search

nodejs / gyp-next

A fork of the GYP build system for use in the Node.js projects
BSD 3-Clause "New" or "Revised" License
125 stars 69 forks source link

fix: duplicate ninja rules for v8 (cross-compiling) #185

Open moto-timo opened 1 year ago

moto-timo commented 1 year ago

avoids duplicate ninja rules for v8 used in host and target

From: https://github.com/minrk/node/commit/5e533cb943eef68b270f55f0cba02c0ec67c699d

Reported in https://github.com/nodejs/node/issues/46690 and https://github.com/nodejs/node/issues/37441

cclauss commented 1 year ago

Please rebase.

moto-timo commented 1 year ago

Rebased again.

moto-timo commented 1 year ago

Rebased to pick up the xml.etree.cElementTree commit.

moto-timo commented 1 year ago

@cclauss I believe I addressed your recommendations and rebase concerns. Anything else that needs to be done or any more discussion?

cclauss commented 1 year ago

This pull request is rebased and the tests are all green. ✅ Thanks for that.

Now what we need is some maintainer who has enough expertise to review and approve or make suggestions.

moto-timo commented 1 year ago

@cclauss great. Thank you for the response.

ryzokuken commented 1 year ago

I can confirm that this goes with the default naming conventions of depot_tools and ninja, but I'd let someone else approve it for sure.