search

nodejs / gyp-next

A fork of the GYP build system for use in the Node.js projects
BSD 3-Clause "New" or "Revised" License
125 stars 69 forks source link

chore: onboard onto Python 3.12-dev and Node 18 #201

Closed rzhao271 closed 10 months ago

rzhao271 commented 11 months ago

Combines https://github.com/nodejs/gyp-next/pull/196 and https://github.com/nodejs/node-gyp/pull/2888

rzhao271 commented 11 months ago

I notice the (windows-latest, 3.8) integration tests contain failed tests, but the error message says gyp verb find Python - version is "3.11.4". @cclauss Is node-gyp not finding Python 3.8 properly?

Other than that, CI looks a lot more green than before.

cclauss commented 11 months ago

If you have a later version of Python installed then node-gyp may try to use it. If py3.11 is disabled before the test runs, it may find 3.8 and pass.

rzhao271 commented 10 months ago

@cclauss PR finally ready to merge.

Reminder: please squash merge the PR.

Afterwards, can https://github.com/nodejs/gyp-next/pull/197 be updated and merged to unblock node-gyp? I'm thinking the other PRs such as lint PRs can be merged later.