nodejs / gyp-next

A fork of the GYP build system for use in the Node.js projects
BSD 3-Clause "New" or "Revised" License
125 stars 69 forks source link

fix: add quotes for command in msvs generator #217

Closed zcbenz closed 8 months ago

zcbenz commented 8 months ago

The msvs generator only added quotes for arguments of the action, the command itself should have quotes too.

Without this change actions will fail when python binary is placed in a path with spaces in it.

Refs https://github.com/nodejs/node/pull/48462.

/cc @gengjiawen